-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: document how to implement a propagator #3351
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendecas
force-pushed
the
doc/propagator
branch
from
October 21, 2022 08:07
aa9ccbb
to
12af34d
Compare
legendecas
force-pushed
the
doc/propagator
branch
from
October 21, 2022 08:09
12af34d
to
8d2a9b6
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3351 +/- ##
=======================================
Coverage 93.25% 93.25%
=======================================
Files 247 247
Lines 7341 7341
Branches 1509 1509
=======================================
Hits 6846 6846
Misses 495 495 |
vmarchaud
approved these changes
Nov 3, 2022
MSNev
approved these changes
Nov 7, 2022
pichlermarc
approved these changes
Nov 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one nit 🙂
Co-authored-by: Marc Pichler <marcpi@edu.aau.at>
dyladan
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes #3258
Document how to define a propagator
Type of change
Checklist: