Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(instrumentation): debug log on no modules defined for instrumentation #3308

Merged
merged 3 commits into from
Oct 17, 2022
Merged

fix(instrumentation): debug log on no modules defined for instrumentation #3308

merged 3 commits into from
Oct 17, 2022

Conversation

legendecas
Copy link
Member

Which problem is this PR solving?

Fixes #3304

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@legendecas legendecas requested a review from a team October 10, 2022 14:57
@codecov
Copy link

codecov bot commented Oct 10, 2022 •
edited
Loading

Codecov Report

Merging #3308 (dc0b748) into main (a7d053a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3308      +/-   ##
==========================================
- Coverage   93.43%   93.42%   -0.02%     
==========================================
  Files         241      241              
  Lines        7253     7253              
  Branches     1507     1507              
==========================================
- Hits         6777     6776       -1     
- Misses        476      477       +1
Impacted Files Coverage Δ
...strumentation/src/platform/node/instrumentation.ts 63.73% <100.00%> (ø)
...-trace-base/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️

@legendecas legendecas mentioned this pull request Oct 13, 2022
Closed
@legendecas legendecas merged commit 92f2359 into open-telemetry:main Oct 17, 2022
@legendecas legendecas deleted the instrumentation-no-modules branch October 17, 2022 02:27
@dyladan dyladan mentioned this pull request Oct 17, 2022
Merged
3 tasks
@dyladan dyladan mentioned this pull request Nov 7, 2022
Closed
@legendecas legendecas mentioned this pull request Jan 12, 2023
Closed
trentm added a commit that referenced this pull request Aug 15, 2024
@trentm
fix(instrumentation): drop diag.debug on InstrumentationBase#init not…
91fccf1 
… returning any modules

Closes: #2237
Refs: #3308
@trentm trentm mentioned this pull request Aug 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyladan dyladan dyladan approved these changes

@vmarchaud vmarchaud vmarchaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simple express app printing odd warning
3 participants
@legendecas @dyladan @vmarchaud