Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(opentelemtry-core): fix header extraction #2832

Merged
merged 6 commits into from
Mar 17, 2022
Merged

fix(opentelemtry-core): fix header extraction #2832

merged 6 commits into from
Mar 17, 2022

Conversation

doronkopit5
Copy link

Which problem is this PR solving?

Solves the problem of extracting the baggage header when it is set inside an array.
Fixes #2831

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added

@doronkopit5 doronkopit5 requested a review from a team March 14, 2022 11:50
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 14, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: doronkopit5 / name: Doron Kopit (b5a6a1c)

@doronkopit5 doronkopit5 mentioned this pull request Mar 14, 2022
Closed
@codecov
Copy link

codecov bot commented Mar 17, 2022 •
edited
Loading

Codecov Report

Merging #2832 (e0b4b74) into main (038bbdb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2832   +/-   ##
=======================================
  Coverage   93.46%   93.47%           
=======================================
  Files         163      163           
  Lines        5543     5544    +1     
  Branches     1167     1168    +1     
=======================================
+ Hits         5181     5182    +1     
  Misses        362      362
Impacted Files Coverage Δ
...re/src/baggage/propagation/W3CBaggagePropagator.ts 97.05% <100.00%> (+0.08%) ⬆️

@dyladan dyladan mentioned this pull request Mar 17, 2022
Merged
@dyladan dyladan added the bug Something isn't working label Mar 17, 2022
dyladan
dyladan approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % one nit

packages/opentelemetry-core/src/baggage/propagation/W3CBaggagePropagator.ts Outdated Show resolved Hide resolved
@dyladan
Copy link
Member

dyladan commented Mar 17, 2022

LGTM but need one more 👍 from an @open-telemetry/javascript-approvers before merge.

legendecas
legendecas reviewed Mar 17, 2022
View reviewed changes
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM % one small nit.

@doronkopit5 @legendecas
use constant
e0b4b74 
Co-authored-by: legendecas <legendecas@gmail.com>
@dyladan dyladan merged commit acb0345 into open-telemetry:main Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weyert weyert weyert left review comments

@dyladan dyladan dyladan approved these changes

@vmarchaud vmarchaud vmarchaud approved these changes

@legendecas legendecas legendecas approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to extract baggage on grpc-js instrumentation
5 participants
@doronkopit5 @dyladan @weyert @vmarchaud @legendecas