Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api-metrics): add schemaUrl to meter creations #2529
feat(api-metrics): add schemaUrl to meter creations #2529
Changes from 1 commit
94b67f1
eafb54f
acb658e
2f442c8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wonder how could we can handle this more cleanly ? i expect this will happen commonly on the feature when experimental requires change on stable packages :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if it is possible to link
packages/*
to the lerna project inexperimental/
. Even if it is possible, I'd believe we need a solution to publish experimental packages apart from the stable ones, that would eventually require a separate lerna project? Maybe @dyladan can chime on this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not possible to link them together with the current setup. We could go back to the way it was before where all packages are part of the same lerna repo but make scripts which call lerna commands only on specific packages and use the
independent
version scheme? Having two groups of packages in lerna seems to be a thorny bit of business that there is no clear cut solution for.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think going back is necessary now. I would prefer to investigate alternative to lerna that suit our use case to avoid putting effort inside it, WDYT ?