Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update typescript getting-started tracing example and docs #2504

Merged

Conversation

mustafain117
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Updated typescript tracing example code to use DiagConsoleLogger for logging, updated docs to match tracing example

@mustafain117 mustafain117 requested a review from a team September 28, 2021 17:58
Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good change to me, but the decision has been made that we should maintain the getting_started in the website docs. I'm going to approve this because it is an improvement, but you should know these changes would be better ported over there.

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #2504 (b96b9c9) into main (be52259) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2504   +/-   ##
=======================================
  Coverage   93.23%   93.23%           
=======================================
  Files         137      137           
  Lines        5042     5042           
  Branches     1066     1066           
=======================================
  Hits         4701     4701           
  Misses        341      341           

@dyladan dyladan added the document Documentation-related label Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no exported member 'LogLevel'
3 participants