Add package: opentelemetry-types #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
requested review from
danielkhan,
iredelmeier,
justindsmith and
yurishkuro
as code owners
danielkhan
reviewed
Jun 12, 2019
danielkhan
reviewed
Jun 12, 2019
|
@rochdev @vmarchaud @hekike @bg451 Please review. |
rochdev
reviewed
Jun 13, 2019
| ## Usage | ||
|
|
||
| ``` | ||
| const opentelemetryTypes = require('opentelemetry-types'); |
There was a problem hiding this comment.
I thought this package only contained the TypeScript definitions?
There was a problem hiding this comment.
Updated the README file, the default content was auto-generated by some extension.
rochdev
approved these changes
Jun 13, 2019
6 tasks
dyladan
pushed a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
* Add ESM build * Use build/esm/ dir
dyladan
pushed a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
* Add ESM build * Use build/esm/ dir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17