Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): roll back dependency @opentelemetry/instrumentation-express to ^0.24.0 #2423

Merged
merged 2 commits into from
Aug 25, 2021
Merged

fix(deps): roll back dependency @opentelemetry/instrumentation-express to ^0.24.0 #2423

merged 2 commits into from
Aug 25, 2021

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Aug 20, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Type Update Change
@opentelemetry/instrumentation-express dependencies rollback ^0.25.0 -> ^0.24.0

Configuration

📅 Schedule: "before 3am on Friday" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate-bot renovate-bot requested a review from a team August 20, 2021 00:06
@forking-renovate forking-renovate bot added the dependencies Pull requests that update a dependency file label Aug 20, 2021
@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #2423 (a21d65c) into main (3cbd530) will increase coverage by 0.90%.
The diff coverage is n/a.

❗ Current head a21d65c differs from pull request most recent head 0c7b41b. Consider uploading reports for the commit 0c7b41b to get more accurate results

@@            Coverage Diff             @@
##             main    #2423      +/-   ##
==========================================
+ Coverage   92.70%   93.61%   +0.90%     
==========================================
  Files         137       55      -82     
  Lines        4990     1754    -3236     
  Branches     1054      360     -694     
==========================================
- Hits         4626     1642    -2984     
+ Misses        364      112     -252     
Impacted Files Coverage Δ
...s/opentelemetry-core/src/platform/node/sdk-info.ts 0.00% <0.00%> (-100.00%) ⬇️
...pentelemetry-core/src/platform/node/performance.ts 0.00% <0.00%> (-100.00%) ⬇️
...emetry-api-metrics/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...ckages/opentelemetry-exporter-zipkin/src/zipkin.ts 84.48% <0.00%> (-15.52%) ⬇️
...kages/opentelemetry-sdk-metrics-base/src/Metric.ts
...y-sdk-trace-base/src/export/ConsoleSpanExporter.ts
packages/opentelemetry-propagator-b3/src/common.ts
packages/opentelemetry-propagator-b3/src/types.ts
...esources/src/platform/node/default-service-name.ts
...emetry-sdk-metrics-base/src/ValueRecorderMetric.ts
... and 76 more

@obecny
Copy link
Member

obecny commented Aug 23, 2021

we should imho remove express instrumentation example from this repo and only have it in contrib

Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@obecny this isn't in the examples, it's in the getting started guide. We can talk about changing the guide to not use contrib packages, but for now we should merge this because it is broken in its current state.

@forking-renovate
Copy link

Autoclosing Skipped

This PR has been flagged for autoclosing, however it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

@obecny obecny merged commit 30733df into open-telemetry:main Aug 25, 2021
@renovate-bot renovate-bot deleted the renovate/opentelemetry-monorepo branch August 25, 2021 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants