Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add startActiveSpan method to Tracer #2221

Merged
merged 27 commits into from
Jun 1, 2021
Merged

feat: add startActiveSpan method to Tracer #2221

merged 27 commits into from
Jun 1, 2021

Commits on May 28, 2021

  1. feat: add startActiveSpan method to Tracer 

    Signed-off-by: naseemkullah <naseem@transit.app>
    naseemkullah committed May 28, 2021
    Configuration menu
    Copy the full SHA
    43283ab View commit details
    Browse the repository at this point in the history

  2. fix: add function overload signatures and remove unneeded typeof checks 

    Signed-off-by: naseemkullah <naseem@transit.app>
    naseemkullah committed May 28, 2021
    Configuration menu
    Copy the full SHA
    f5c5a88 View commit details
    Browse the repository at this point in the history

  3. chore: function overloads 

    Signed-off-by: naseemkullah <naseem@transit.app>

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
    @dyladan
    naseemkullah and dyladan committed May 28, 2021
    Configuration menu
    Copy the full SHA
    fe3681e View commit details
    Browse the repository at this point in the history

  4. chore: change var names 

    Signed-off-by: naseemkullah <naseem@transit.app>
    naseemkullah committed May 28, 2021
    Configuration menu
    Copy the full SHA
    3e69e73 View commit details
    Browse the repository at this point in the history

  5. test: startActiveSpan in Tracer 

    Signed-off-by: naseemkullah <naseem@transit.app>
    naseemkullah committed May 28, 2021
    Configuration menu
    Copy the full SHA
    0a6307f View commit details
    Browse the repository at this point in the history

  6. fix: startactiveSpan test 

    Signed-off-by: naseemkullah <naseem@transit.app>
    naseemkullah committed May 28, 2021
    Configuration menu
    Copy the full SHA
    6f9b8df View commit details
    Browse the repository at this point in the history

  7. feat: add reset script 

    Signed-off-by: naseemkullah <naseem@transit.app>
    naseemkullah committed May 28, 2021
    Configuration menu
    Copy the full SHA
    9f1521e View commit details
    Browse the repository at this point in the history

  8. chore: organize imports 

    Signed-off-by: naseemkullah <naseem@transit.app>
    naseemkullah committed May 28, 2021
    Configuration menu
    Copy the full SHA
    b1816b9 View commit details
    Browse the repository at this point in the history

  9. test: split combined test into 4 tests 

    Signed-off-by: naseemkullah <naseem@transit.app>
    naseemkullah committed May 28, 2021
    Configuration menu
    Copy the full SHA
    333932e View commit details
    Browse the repository at this point in the history

  10. test: startActiveSpan ensure that ctx sent is used 

    also add commented out span equality assertions to be uncommented before
merging

Signed-off-by: naseemkullah <naseem@transit.app>
    naseemkullah committed May 28, 2021
    Configuration menu
    Copy the full SHA
    ee7a305 View commit details
    Browse the repository at this point in the history

  11. chore: organize imports 

    Signed-off-by: naseemkullah <naseem@transit.app>
    naseemkullah committed May 28, 2021
    Configuration menu
    Copy the full SHA
    3ab1fe4 View commit details
    Browse the repository at this point in the history

  12. chore: clarify todo 

    Signed-off-by: naseemkullah <naseem@transit.app>
    naseemkullah committed May 28, 2021
    Configuration menu
    Copy the full SHA
    02b5dfd View commit details
    Browse the repository at this point in the history

  13. test: startActiveSpan in NodeTracer 

    Signed-off-by: naseemkullah <naseem@transit.app>
    naseemkullah committed May 28, 2021
    Configuration menu
    Copy the full SHA
    a1e5bdb View commit details
    Browse the repository at this point in the history

  14. chore: put active span tests in own describe block 

    Signed-off-by: naseemkullah <naseem@transit.app>
    naseemkullah committed May 28, 2021
    Configuration menu
    Copy the full SHA
    0a00ddf View commit details
    Browse the repository at this point in the history

  15. test: startActiveSpan in WebTracer 

    Signed-off-by: naseemkullah <naseem@transit.app>
    naseemkullah committed May 28, 2021
    Configuration menu
    Copy the full SHA
    e6eb4f7 View commit details
    Browse the repository at this point in the history

  16. chore: remove Tracer specific tests from Node and Web Tracers 

    Signed-off-by: naseemkullah <naseem@transit.app>
    naseemkullah committed May 28, 2021
    Configuration menu
    Copy the full SHA
    41ff0b1 View commit details
    Browse the repository at this point in the history

  17. fix: conflicts 

    Signed-off-by: naseemkullah <naseem@transit.app>
    naseemkullah committed May 28, 2021
    Configuration menu
    Copy the full SHA
    374c5ea View commit details
    Browse the repository at this point in the history

  18. chore: remove git clean form reset script 

    Signed-off-by: naseemkullah <naseem@transit.app>
    naseemkullah committed May 28, 2021
    Configuration menu
    Copy the full SHA
    63ec701 View commit details
    Browse the repository at this point in the history

  19. fix: conflicts 

    Signed-off-by: naseemkullah <naseem@transit.app>
    naseemkullah committed May 28, 2021
    Configuration menu
    Copy the full SHA
    0afe1ee View commit details
    Browse the repository at this point in the history

  20. fix: use span.spanContext() 

    Signed-off-by: naseemkullah <naseem@transit.app>
    naseemkullah committed May 28, 2021
    Configuration menu
    Copy the full SHA
    5532776 View commit details
    Browse the repository at this point in the history

  21. fix: adhere to breaking changes in new api 

    Signed-off-by: naseemkullah <naseem@transit.app>
    naseemkullah committed May 28, 2021
    Configuration menu
    Copy the full SHA
    4219630 View commit details
    Browse the repository at this point in the history

  22. chore: only import api once 

    Signed-off-by: naseemkullah <naseem@transit.app>
    naseemkullah committed May 28, 2021
    Configuration menu
    Copy the full SHA
    0335473 View commit details
    Browse the repository at this point in the history

  23. test: assert active spans are indeed active with help of TestStackCon… 

    …textManager

Signed-off-by: naseemkullah <naseem@transit.app>
    naseemkullah committed May 28, 2021
    Configuration menu
    Copy the full SHA
    1944b4e View commit details
    Browse the repository at this point in the history

  24. test: spy startSpan to ensure it is called with opts passed into star… 

    …tActiveSpan

Signed-off-by: naseemkullah <naseem@transit.app>
    naseemkullah committed May 28, 2021
    Configuration menu
    Copy the full SHA
    ec33257 View commit details
    Browse the repository at this point in the history

  25. fix: uncomment sinon spy 

    Signed-off-by: naseemkullah <naseem@transit.app>
    naseemkullah committed May 28, 2021
    Configuration menu
    Copy the full SHA
    c395c81 View commit details
    Browse the repository at this point in the history

  26. test: assert startSpan spy called with name when only name and fn pas… 

    …sed to startActiveSpan

Signed-off-by: naseemkullah <naseem@transit.app>
    naseemkullah committed May 28, 2021
    Configuration menu
    Copy the full SHA
    4eb9d6c View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2021

  1. Merge branch 'main' into start-active-span

    @dyladan
    dyladan authored Jun 1, 2021
    Configuration menu
    Copy the full SHA
    d5bab9b View commit details
    Browse the repository at this point in the history