-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: pin API dependency #2213
Conversation
As long as API is not GA breaking changes are expected therefore API version should be pinned.
regarding lint fails see #2204 No idea yet why collector-exporter-grpc tests fail |
once published to npm, a user installing core and API versions with: User will have to actively understand that he needs to install a specific version of api like this: |
I agree that tags on NPM should be also synced somehow. But that's not directly related to this PR I guess. |
opened an issue in api repo: |
added a commit to workaround the lint problems. Happy to remove if here are better solutions. But the question why collector-exporter-grpc tests fail remains. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
holding this for now, after talking with maintainers, there is new rc2 which is rc0, should replace the broken rc1. and there will be new plan to handle that
We are releasing the old rc.0 as rc.2 to fix users who have depended on carat ranges. We will deprecate all |
ok, closed this one and the corresponding one in contrib: open-telemetry/opentelemetry-js-contrib#491 |
Which problem is this PR solving?
see #2212 (comment)
Short description of the changes
As long as API is not GA breaking changes are expected therefore API version should be pinned.