Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use span interface from API #2075

Closed
wants to merge 3 commits into from
Closed

chore: use span interface from API #2075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f6a8e41
chore: use span interface from API
dyladan Apr 5, 2021
6353425
chore: use interface for consistency
dyladan Apr 7, 2021
ce482c4
Merge remote-tracking branch 'origin/main' into span-processor-interface
dyladan Apr 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/opentelemetry-tracing/src/MultiSpanProcessor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,9 @@
* limitations under the License.
*/

import { Context } from '@opentelemetry/api';
import { Context, Span } from '@opentelemetry/api';
import { globalErrorHandler } from '@opentelemetry/core';
import { ReadableSpan } from './export/ReadableSpan';
import { Span } from './Span';
import { SpanProcessor } from './SpanProcessor';

/**
Expand Down
3 changes: 1 addition & 2 deletions packages/opentelemetry-tracing/src/NoopSpanProcessor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,8 @@
* limitations under the License.
*/

import { Context } from '@opentelemetry/api';
import { Context, Span } from '@opentelemetry/api';
import { ReadableSpan } from './export/ReadableSpan';
import { Span } from './Span';
import { SpanProcessor } from './SpanProcessor';

/** No-op implementation of SpanProcessor */
Expand Down
3 changes: 1 addition & 2 deletions packages/opentelemetry-tracing/src/SpanProcessor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,8 @@
* limitations under the License.
*/

import { Context } from '@opentelemetry/api';
import { Context, Span } from '@opentelemetry/api';
import { ReadableSpan } from './export/ReadableSpan';
import { Span } from './Span';

/**
* SpanProcessor is the interface Tracer SDK uses to allow synchronous hooks
Expand Down
3 changes: 1 addition & 2 deletions packages/opentelemetry-tracing/src/export/BatchSpanProcessor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,13 @@
* limitations under the License.
*/

import { context, suppressInstrumentation } from '@opentelemetry/api';
import { context, Span, suppressInstrumentation } from '@opentelemetry/api';
import {
ExportResultCode,
globalErrorHandler,
unrefTimer,
getEnv,
} from '@opentelemetry/core';
import { Span } from '../Span';
import { SpanProcessor } from '../SpanProcessor';
import { BufferConfig } from '../types';
import { ReadableSpan } from './ReadableSpan';
Expand Down
3 changes: 1 addition & 2 deletions packages/opentelemetry-tracing/src/export/SimpleSpanProcessor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,8 @@
* limitations under the License.
*/

import { context, suppressInstrumentation } from '@opentelemetry/api';
import { context, suppressInstrumentation, Span } from '@opentelemetry/api';
import { ExportResultCode, globalErrorHandler } from '@opentelemetry/core';
import { Span } from '../Span';
import { SpanExporter } from './SpanExporter';
import { SpanProcessor } from '../SpanProcessor';
import { ReadableSpan } from './ReadableSpan';
Expand Down