Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: create NoopSpan instead reusing NOOP_SPAN #1899

Merged
merged 10 commits into from
Feb 10, 2021
Merged

chore: create NoopSpan instead reusing NOOP_SPAN #1899

merged 10 commits into from
Feb 10, 2021

Commits on Feb 4, 2021

  1. chore: create NoopSpan instead reusing NOOP_SPAN 

    Always create a fresh NoopSpan instead of returning the same NOOP_SPAN several times.

Users may attach some data to a span or use it as a key in a map.
Avoid issues/leaks in such cases by always returning a new NoopSpan.
    @Flarna
    Flarna committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    3ffd996 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into rm-noopspan

    @Flarna
    Flarna authored Feb 4, 2021
    Configuration menu
    Copy the full SHA
    1695c32 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2021

  1. Merge remote-tracking branch 'upstream/main' into rm-noopspan

    @Flarna
    Flarna committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    05a1ae2 View commit details
    Browse the repository at this point in the history

  2. chore: use NOOP_TRACER.startSpan() 

    Remove NoopSpan from API and use NOOP_TRACER.startSpan() to create them.
Remove NoRecordingSpan and replace creation of them by NOOP_TRACER.startSpan().
    @Flarna
    Flarna committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    2b46339 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into rm-noopspan

    @Flarna
    Flarna authored Feb 5, 2021
    Configuration menu
    Copy the full SHA
    092fdb3 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2021

  1. Merge branch 'main' into rm-noopspan

    @Flarna
    Flarna authored Feb 8, 2021
    Configuration menu
    Copy the full SHA
    0d7c8d8 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into rm-noopspan

    @Flarna
    Flarna committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    42d6f0c View commit details
    Browse the repository at this point in the history

  3. chore: fix merge errors

    @Flarna
    Flarna committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    877b780 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2021

  1. Merge branch 'main' into rm-noopspan

    @Flarna
    Flarna authored Feb 9, 2021
    Configuration menu
    Copy the full SHA
    2ad54f0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into rm-noopspan

    @Flarna
    Flarna authored Feb 9, 2021
    Configuration menu
    Copy the full SHA
    fe492e1 View commit details
    Browse the repository at this point in the history