-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: create NoopSpan instead reusing NOOP_SPAN #1899
Merged
dyladan
merged 10 commits into
open-telemetry:main
from
dynatrace-oss-contrib:rm-noopspan
Feb 10, 2021
Merged
chore: create NoopSpan instead reusing NOOP_SPAN #1899
dyladan
merged 10 commits into
open-telemetry:main
from
dynatrace-oss-contrib:rm-noopspan
Feb 10, 2021
Commits on Feb 4, 2021
-
chore: create NoopSpan instead reusing NOOP_SPAN
Always create a fresh NoopSpan instead of returning the same NOOP_SPAN several times. Users may attach some data to a span or use it as a key in a map. Avoid issues/leaks in such cases by always returning a new NoopSpan.
Configuration menu - View commit details
-
Copy full SHA for 3ffd996 - Browse repository at this point
Copy the full SHA 3ffd996View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1695c32 - Browse repository at this point
Copy the full SHA 1695c32View commit details
Commits on Feb 5, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 05a1ae2 - Browse repository at this point
Copy the full SHA 05a1ae2View commit details -
chore: use NOOP_TRACER.startSpan()
Remove NoopSpan from API and use NOOP_TRACER.startSpan() to create them. Remove NoRecordingSpan and replace creation of them by NOOP_TRACER.startSpan().
Configuration menu - View commit details
-
Copy full SHA for 2b46339 - Browse repository at this point
Copy the full SHA 2b46339View commit details -
Configuration menu - View commit details
-
Copy full SHA for 092fdb3 - Browse repository at this point
Copy the full SHA 092fdb3View commit details
Commits on Feb 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 0d7c8d8 - Browse repository at this point
Copy the full SHA 0d7c8d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 42d6f0c - Browse repository at this point
Copy the full SHA 42d6f0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 877b780 - Browse repository at this point
Copy the full SHA 877b780View commit details
Commits on Feb 9, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 2ad54f0 - Browse repository at this point
Copy the full SHA 2ad54f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe492e1 - Browse repository at this point
Copy the full SHA fe492e1View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.