Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: deprecate attribute.component #1220

Merged

Conversation

markwolff
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • Removes all instances of core auto-instrumentations applying the component attribute
  • After release of semantic-conventions plugin, contrib plugins should also be refactored in the same way.

@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #1220 into master will decrease coverage by 0.00%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master    #1220      +/-   ##
==========================================
- Coverage   93.24%   93.23%   -0.01%     
==========================================
  Files         122      122              
  Lines        3551     3550       -1     
  Branches      714      714              
==========================================
- Hits         3311     3310       -1     
  Misses        240      240              
Impacted Files Coverage Δ
...elemetry-semantic-conventions/src/trace/general.ts 0.00% <0.00%> (ø)
packages/opentelemetry-plugin-grpc/src/grpc.ts 96.79% <100.00%> (ø)
packages/opentelemetry-plugin-http/src/http.ts 97.89% <100.00%> (-0.02%) ⬇️
...s/opentelemetry-plugin-xml-http-request/src/xhr.ts 93.88% <100.00%> (ø)

@naseemkullah
Copy link
Member

naseemkullah commented Jun 19, 2020

lgtm except for failing browser test

edit: I updated the branch in hopes it would magically help browser test pass 🤷‍♂️

@dyladan
Copy link
Member

dyladan commented Jun 19, 2020

I really don't see what changed that makes the browser test fail

@mayurkale22
Copy link
Member

Are you planning to apply the same change in js-contrib repo?

@mayurkale22
Copy link
Member

Please fix the conflicts, looks good to go.

@mayurkale22 mayurkale22 merged commit 806eabd into open-telemetry:master Jun 24, 2020
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecate attribute.component
4 participants