use LabelValues<string> instead labelValues #1141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivkanya9146
requested review from
bg451,
dyladan,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
dyladan
reviewed
Jun 3, 2020
| @@ -160,7 +160,7 @@ export class PrometheusExporter implements MetricExporter { | |||
| } | |||
|
|
|||
| private _getLabelValues(keys: string[], labels: api.Labels) { | |||
| const labelValues: labelValues = {}; | |||
| LabelValues<string> = {}; | |||
There was a problem hiding this comment.
This overwrites the variable from prom-client which I'm sure is not what was intended. Did you mean to do this?
Suggested change
| LabelValues<string> = {}; | |
| const labelValues: LabelValues<string> = {}; |
There was a problem hiding this comment.
This was by mistake, i wanted to add commit to other PR.
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
…try#1141) * fix(compile-examples): fixed compile examples error * fix(compile-examples): align all typescipt versions to 4.3.5 * fix(compile-examples): align all typescipt versions to 4.3.5 * fix(compile-examples): moved @types/mongodb to a dev dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
-change labelValues to LabelValues.
Short description of the changes
-use LabelValues instead labelValues