Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 0.8.0 release proposal #1046

Merged
merged 4 commits into from
May 12, 2020

Conversation

mayurkale22
Copy link
Member

@mayurkale22 mayurkale22 commented May 11, 2020

@mayurkale22 mayurkale22 changed the title 0.8.0 proposal chore: 0.8.0 release proposal May 11, 2020
@mayurkale22
Copy link
Member Author

@acheraime FYI

@mayurkale22 mayurkale22 mentioned this pull request May 11, 2020
@acheraime
Copy link

acheraime commented May 12, 2020 via email

@vmarchaud
Copy link
Member

would be cool if we could include #1038 but not a hard requirement

@obecny
Copy link
Member

obecny commented May 12, 2020

are we gonna include #981 into this release too ?

Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's more here than I expected. LGTM

@dyladan
Copy link
Member

dyladan commented May 12, 2020

would be cool if we could include #1038 but not a hard requirement

I think since there are currently no reviews and @acheraime is waiting on this release for a demo they are supposed to do today, we probably can't get that one in.

are we gonna include #981 into this release too ?

I would like to, but it currently has 3 reviews which seems low for something that is so important to the underlying system? I could go either way on this. @mayurkale22 WDYT?

edit: just saw mayur already added the merge label. I'm going to merge that so it can be included in this.

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mayurkale22 mayurkale22 merged commit 94f7c4f into open-telemetry:master May 12, 2020
@mayurkale22 mayurkale22 deleted the 0.8.0-proposal branch May 12, 2020 16:33
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Co-authored-by: Rauno Viskus <Rauno56@users.noreply.github.com>
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants