express plugin: multiple .end() call & .setStatus after .end() of span

[mayurkale22]

Please answer these questions before submitting a bug report.

What version of OpenTelemetry are you using?

0.5.2

What did you do?

Run express example.

What did you expect to see?

Execute without error/warn.

What did you see instead?

Can not execute the operation on ended Span {traceId: 87464894ec5751e4af73cb8915bb4830, spanId: 0410a78c7f08acb2}
Can not execute the operation on ended Span {traceId: 87464894ec5751e4af73cb8915bb4830, spanId: 0410a78c7f08acb2}
You can only call end() on a span once.

[vmarchaud]

Guess thats coming from the fact that i'm trying to guess if one layer called the next callback or not (here). I will look into it tomorrow if no one does it before

[mayurkale22]

Yes, looks like due to:

opentelemetry-js/packages/opentelemetry-plugin-express/src/express.ts

Lines 210 to 212 in f695e40

	if (callbackHasBeenCalled === false) {
	span.end();
	}

[vmarchaud]

This has landed on the contrib repo, release pending open-telemetry/opentelemetry-js-contrib#6