ioredis plugin breaks ioredis

[dyladan]

At the end of the constructor, the ioredis plugin returns this._moduleExports.prototype;. The types don't complain, but the ioredis module is completely broken and unuseable.

fix: return return this._moduleExports;

[naseemkullah]

Thanks! Why is it that tests passed? I copy pasted the return from another plugin I believe

[dyladan]

The tests do not use the plugin loader, so they are independent from this behavior.

None of the other plugins have this behavior from a cursory check.

[naseemkullah]

I think I was inspired by

opentelemetry-js/packages/opentelemetry-plugin-redis/src/redis.ts

Line 41 in 8b62485

this._moduleExports.RedisClient.prototype,

without quite understanding.

Anyhow, you think it's possible/worth it to include plugin loader in tests?

[dyladan]

I can't think of an easy way to do that, and I don't want the test to depend on an outside component. In this case it was unfortunate that the module exports prototype happened to have the same type as the module exports. In most cases that won't be true. I'm not sure what would be a good general way to test this.

[naseemkullah]

Sounds good, thanks.