Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test to ensure plugins are targeting latest versions #669

Closed
1 task done
dyladan opened this issue Jan 6, 2020 · 1 comment
Closed
1 task done

Add a test to ensure plugins are targeting latest versions #669

dyladan opened this issue Jan 6, 2020 · 1 comment

Comments

@dyladan
Copy link
Member

dyladan commented Jan 6, 2020

  • This only affects the JavaScript OpenTelemetry library

In order to avoid issues like #668, I am suggesting we add a test in the ci which iterates over the plugins, checks their version specifiers, and ensures that the latest npm version matches the version specifier. I am not aware of any plugins we have right now which are not targeting the latest npm version.
@dyladan dyladan mentioned this issue Jan 6, 2020
Closed
@svetlanabrennan
Copy link
Contributor

Shouldn't this be closed since PR #670 fixed the issue?

@dyladan dyladan closed this as completed Aug 18, 2022
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@dyladan
feat: upstream mocha instrumentation testing plugin from ext-js open-…
a5170c4 
…telemetry#621 (open-telemetry#669)
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this issue Mar 16, 2024
@dyladan
feat: upstream mocha instrumentation testing plugin from ext-js open-…
8174a0e 
…telemetry#621 (open-telemetry#669)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: add test to ensure plugins support latest module versions dynatrace-oss-contrib/opentelemetry-js
2 participants
@dyladan @svetlanabrennan