Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New trace is created in presence of x-cloud-trace-context #1136

Closed
1 of 2 tasks
sk- opened this issue Jun 3, 2020 · 2 comments
Closed
1 of 2 tasks

New trace is created in presence of x-cloud-trace-context #1136

sk- opened this issue Jun 3, 2020 · 2 comments

Comments

@sk-
Copy link

sk- commented Jun 3, 2020

  • This only affects the JavaScript OpenTelemetry library
  • This may affect other libraries, but I would like to get opinions here first

I'm trying to trace Firebase Cloud Functions, and so far the http and https plugins are generating the spans, however, a new trace id is created instead of reusing the one provided in the context.

The request I receive has the header x-cloud-trace-context. Below an example value I got:

x-cloud-trace-context: 97be22054737c8368a6173b7b5b3ac12/9492297704906512426;o=1

One of the issues this has is that the logs generated in my app have the trace 97be22054737c8368a6173b7b5b3ac12, so that they are not attached the trace.

Is it something that I'm missing?

@dyladan
Copy link
Member

dyladan commented Jun 3, 2020

OpenTelemetry does not support vendor-specific trace headers. Maybe @mayurkale22 knows if there are plans to create a propagator for this in the future?

@mayurkale22
Copy link
Member

GoogleCloudPlatform/opentelemetry-operations-js#26 this is the original issue. AFAIK no one is working on the issue, feel free to comment on original issue if you like to work on it.

@dyladan dyladan closed this as completed Jun 3, 2020
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
…ing open-telemetry#1136 (open-telemetry#1138)

* ci: [Bug] DNS Lookup and Promise Lookup test for error NOT_FOUND failing open-telemetry#1136

* chore: automatically fix lint issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants