Skip to content

Commit

Permalink
fix(instrumentation): drop diag.debug on InstrumentationBase#init not…
Browse files Browse the repository at this point in the history
… returning any modules (#4925)
  • Loading branch information
trentm committed Aug 19, 2024
1 parent bb67268 commit fb4619b
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 8 deletions.
1 change: 1 addition & 0 deletions experimental/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ All notable changes to experimental packages in this project will be documented

* fix(instrumentation-http): Ensure instrumentation of `http.get` and `https.get` work when used in ESM code [#4857](https://github.com/open-telemetry/opentelemetry-js/issues/4857) @trentm
* fix(api-logs): align AnyValue to spec [#4893](https://github.com/open-telemetry/opentelemetry-js/pull/4893) @blumamir
* fix(instrumentation): remove diag.debug() message for instrumentations that do not patch modules [#4925](https://github.com/open-telemetry/opentelemetry-js/pull/4925) @trentm

### :books: (Refine Doc)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,6 @@ export abstract class InstrumentationBase<

this._modules = (modules as InstrumentationModuleDefinition[]) || [];

if (this._modules.length === 0) {
diag.debug(
'No modules instrumentation has been defined for ' +
`'${this.instrumentationName}@${this.instrumentationVersion}'` +
', nothing will be patched'
);
}

if (this._config.enabled) {
this.enable();
}
Expand Down

0 comments on commit fb4619b

Please sign in to comment.