Skip to content

Commit

Permalink
fix(otlp-exporter): update HistogramAggregation to ExplicitBucketHist…
Browse files Browse the repository at this point in the history
…ogramAggreagtion.
  • Loading branch information
pichlermarc committed Apr 1, 2022
1 parent f3208c8 commit 1991709
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import { Resource } from '@opentelemetry/resources';
import * as assert from 'assert';
import * as grpc from '@grpc/grpc-js';
import { VERSION } from '@opentelemetry/core';
import { HistogramAggregation, MeterProvider, MetricReader } from '@opentelemetry/sdk-metrics-base';
import { ExplicitBucketHistogramAggregation, MeterProvider, MetricReader } from '@opentelemetry/sdk-metrics-base';

export class TestMetricReader extends MetricReader {
protected onForceFlush(): Promise<void> {
Expand Down Expand Up @@ -86,7 +86,7 @@ export function mockObservableGauge(

export function mockHistogram(): Histogram {
const name = 'int-histogram';
meterProvider.addView({ aggregation: new HistogramAggregation([0, 100]) });
meterProvider.addView({ aggregation: new ExplicitBucketHistogramAggregation([0, 100]) });

return meter.createHistogram(name, {
description: 'sample histogram description',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

import { Counter, Histogram, ObservableResult, ValueType, } from '@opentelemetry/api-metrics';
import { InstrumentationLibrary, VERSION } from '@opentelemetry/core';
import { HistogramAggregation, MeterProvider, MetricReader } from '@opentelemetry/sdk-metrics-base';
import { ExplicitBucketHistogramAggregation, MeterProvider, MetricReader } from '@opentelemetry/sdk-metrics-base';
import { Resource } from '@opentelemetry/resources';
import * as assert from 'assert';
import { otlpTypes } from '@opentelemetry/exporter-trace-otlp-http';
Expand Down Expand Up @@ -133,7 +133,7 @@ export function mockHistogram(): Histogram {
const name = 'int-histogram';

meterProvider.addView({
aggregation: new HistogramAggregation([0, 100])
aggregation: new ExplicitBucketHistogramAggregation([0, 100])
},
{
instrument: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,11 @@ import { otlpTypes } from '@opentelemetry/exporter-trace-otlp-http';
import { Resource } from '@opentelemetry/resources';
import * as assert from 'assert';
import { Stream } from 'stream';
import { HistogramAggregation, MeterProvider, MetricReader } from '@opentelemetry/sdk-metrics-base';
import {
ExplicitBucketHistogramAggregation,
MeterProvider,
MetricReader
} from '@opentelemetry/sdk-metrics-base';

export class TestMetricReader extends MetricReader {
protected onForceFlush(): Promise<void> {
Expand Down Expand Up @@ -90,7 +94,7 @@ export function mockObservableGauge(

export function mockHistogram(): Histogram {
const name = 'int-histogram';
meterProvider.addView({ aggregation: new HistogramAggregation([0, 100]) });
meterProvider.addView({ aggregation: new ExplicitBucketHistogramAggregation([0, 100]) });

return meter.createHistogram(name, {
description: 'sample histogram description',
Expand Down

0 comments on commit 1991709

Please sign in to comment.