Skip to content

Commit

Permalink
chore: fixing path of instrumentation file for different systems (#1999)
Browse files Browse the repository at this point in the history
  • Loading branch information
obecny authored Mar 12, 2021
1 parent d6e9654 commit 0c7fef7
Show file tree
Hide file tree
Showing 2 changed files with 40 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,17 @@
*/

import { InstrumentationModuleFile } from './types';
import { normalize } from 'path';

export class InstrumentationNodeModuleFile<T>
implements InstrumentationModuleFile<T> {
public name: string;
constructor(
public name: string,
name: string,
public supportedVersions: string[],
public patch: (moduleExports: T, moduleVersion?: string) => T,
public unpatch: (moduleExports?: T, moduleVersion?: string) => void
) {}
) {
this.name = normalize(name);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
/*
* Copyright The OpenTelemetry Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

import * as assert from 'assert';
import { normalize } from 'path';
import { InstrumentationNodeModuleFile } from '../../src';

describe('InstrumentationNodeModuleFile', () => {
it('should convert path', () => {
const tests = ['c:\\\\foo\\\\bar\\aa', '///home//foo/bar///aa'];
tests.forEach(name => {
const instrumentationNodeModuleFile = new InstrumentationNodeModuleFile(
name,
[],
() => {},
() => {}
);
assert.strictEqual(instrumentationNodeModuleFile.name, normalize(name));
});
});
});

0 comments on commit 0c7fef7

Please sign in to comment.