Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid leaking winston types #932

Merged
merged 1 commit into from
Mar 6, 2022

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Mar 3, 2022

Which problem is this PR solving?

Fixes #925

Short description of the changes

The winston instrumentation needs the winston types only internaly.
Move them into an internal file to avoid leaking it to end user.

Checklist

  • Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

The winston instrumentation needs the winston types only internaly.
Move them into an internal file to avoid leaking it to end user.
@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #932 (48be567) into main (da792fe) will decrease coverage by 2.88%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #932      +/-   ##
==========================================
- Coverage   95.87%   92.98%   -2.89%     
==========================================
  Files          18       19       +1     
  Lines        1067     1155      +88     
  Branches      217      232      +15     
==========================================
+ Hits         1023     1074      +51     
- Misses         44       81      +37     
Impacted Files Coverage Δ
...try-instrumentation-winston/src/instrumentation.ts 57.95% <ø> (ø)

@vmarchaud vmarchaud added the bug Something isn't working label Mar 5, 2022
@rauno56 rauno56 merged commit 31c4886 into open-telemetry:main Mar 6, 2022
@dyladan dyladan mentioned this pull request Mar 6, 2022
@Flarna Flarna deleted the winston-no-types-leak branch March 6, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

winston2 installation is required for using the WinstonInstrumentation
3 participants