Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update manifest to include missing packages #921

Merged
merged 3 commits into from
Feb 28, 2022
Merged

chore: update manifest to include missing packages #921

merged 3 commits into from
Feb 28, 2022

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Feb 25, 2022

@dyladan dyladan requested a review from a team February 25, 2022 19:07
@dyladan dyladan mentioned this pull request Feb 25, 2022
Closed
@codecov
Copy link

codecov bot commented Feb 25, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@c87e952). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #921   +/-   ##
=======================================
  Coverage        ?   95.91%           
=======================================
  Files           ?       13           
  Lines           ?      856           
  Branches        ?      178           
=======================================
  Hits            ?      821           
  Misses          ?       35           
  Partials        ?        0

blumamir
blumamir approved these changes Feb 27, 2022
View reviewed changes
Copy link
Member

@blumamir blumamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
so when adding new packages, the manifest should be updated as well as the release-please-config.json file, right?
If so I'll update the amqplib PR

@blumamir blumamir mentioned this pull request Feb 27, 2022
Merged
1 task
@dyladan
Copy link
Member Author

dyladan commented Feb 28, 2022

Thanks! so when adding new packages, the manifest should be updated as well as the release-please-config.json file, right? If so I'll update the amqplib PR

if you leave it off it uses 1.0.0 as the default first version for release. this might be configurable.

@dyladan dyladan merged commit 129d4ee into open-telemetry:main Feb 28, 2022
@dyladan dyladan deleted the manifest-fix branch February 28, 2022 13:57
@blumamir blumamir mentioned this pull request Feb 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmarchaud vmarchaud vmarchaud approved these changes

@blumamir blumamir blumamir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dyladan @vmarchaud @blumamir