Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphql): move graphql to dependencies #850

Merged
merged 3 commits into from
Jan 27, 2022

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Jan 24, 2022

Fixes #802

Move graphql to dependencies in order to avoid a compilation failure during lib check (instrumentation imports graphql when it is not installed). This is affecting all users of the metapackage which installs the instrumentation but does not install graphql which it depends on.

@dyladan dyladan added the bug Something isn't working label Jan 24, 2022
@dyladan dyladan requested a review from a team January 24, 2022 21:49
@github-actions github-actions bot requested a review from obecny January 24, 2022 21:49
@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #850 (e8c31c0) into main (08b5615) will decrease coverage by 0.61%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #850      +/-   ##
==========================================
- Coverage   95.29%   94.68%   -0.62%     
==========================================
  Files          10       17       +7     
  Lines         701     1128     +427     
  Branches      142      229      +87     
==========================================
+ Hits          668     1068     +400     
- Misses         33       60      +27     
Impacted Files Coverage Δ
.../opentelemetry-instrumentation-graphql/src/enum.ts 100.00% <0.00%> (ø)
...nstrumentation-graphql/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...try-instrumentation-graphql/src/instrumentation.ts 91.61% <0.00%> (ø)
...opentelemetry-instrumentation-graphql/src/types.ts 100.00% <0.00%> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts 96.77% <0.00%> (ø)
...opentelemetry-instrumentation-graphql/src/utils.ts 93.40% <0.00%> (ø)
...entelemetry-instrumentation-graphql/src/symbols.ts 100.00% <0.00%> (ø)

@dyladan dyladan merged commit 18e4f93 into open-telemetry:main Jan 27, 2022
@dyladan dyladan deleted the graphql-dep branch January 27, 2022 20:27
@dyladan dyladan mentioned this pull request Feb 28, 2022
@Flarna Flarna mentioned this pull request May 9, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@opentelemetry/instrumentation-graphql Version 0.27.1 Missing @types/graphql dependency
4 participants