Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add markdown lint and fixed markdown files #716

Merged
merged 6 commits into from
Nov 21, 2021

Conversation

arbiv
Copy link
Contributor

@arbiv arbiv commented Oct 28, 2021

Which problem is this PR solving?

#396

Short description of the changes

Added lint for markdown

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 28, 2021

CLA Signed

The committers are authorized under a signed CLA.

@arbiv arbiv closed this Oct 28, 2021
@arbiv arbiv reopened this Oct 28, 2021
@arbiv arbiv force-pushed the add-markdown-lint branch 2 times, most recently from 84d2029 to f16d09f Compare November 3, 2021 08:12
@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #716 (ac74835) into main (572ed66) will decrease coverage by 2.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #716      +/-   ##
==========================================
- Coverage   96.87%   94.70%   -2.18%     
==========================================
  Files          11      135     +124     
  Lines         640     9948    +9308     
  Branches      126     1008     +882     
==========================================
+ Hits          620     9421    +8801     
- Misses         20      527     +507     
Impacted Files Coverage Δ
...e/opentelemetry-instrumentation-pg/test/pg.test.ts 95.01% <0.00%> (ø)
...ackages/opentelemetry-host-metrics/src/stats/si.ts 66.66% <0.00%> (ø)
...y-instrumentation-memcached/src/instrumentation.ts 96.42% <0.00%> (ø)
...extension-autoinjection/src/contentScript/index.ts 0.00% <0.00%> (ø)
...er-extension-autoinjection/src/background/index.ts 0.00% <0.00%> (ø)
...metry-resource-detector-gcp/src/detectors/index.ts 100.00% <0.00%> (ø)
...ry-instrumentation-aws-sdk/test/aws-sdk-v2.test.ts 100.00% <0.00%> (ø)
...or-aws/test/detectors/AwsBeanstalkDetector.test.ts 100.00% <0.00%> (ø)
...extension-autoinjection/test/contentScript.test.ts 100.00% <0.00%> (ø)
...telemetry-instrumentation-mysql/test/index.test.ts 98.39% <0.00%> (ø)
... and 114 more

@arbiv arbiv force-pushed the add-markdown-lint branch 3 times, most recently from bd9b5ad to 491d518 Compare November 7, 2021 11:53
@arbiv arbiv changed the title feat: Add markdown lint ci: add markdown lint and fixed markdown files Nov 7, 2021
@arbiv arbiv marked this pull request as ready for review November 7, 2021 15:29
@arbiv arbiv requested a review from a team November 7, 2021 15:29
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arbiv arbiv requested a review from dyladan November 9, 2021 13:25
@arbiv
Copy link
Contributor Author

arbiv commented Nov 9, 2021

UT failure and coverage decrease seems irrelevant to the changes in the PR

@arbiv
Copy link
Contributor Author

arbiv commented Nov 14, 2021

@dyladan I fixed the comment, can you please re-review it?

@vmarchaud
Copy link
Member

@arbiv Could you please fix the conflict so we can merge this ?

@arbiv
Copy link
Contributor Author

arbiv commented Nov 21, 2021

@vmarchaud Fixed conflict

@vmarchaud vmarchaud merged commit e5a65c6 into open-telemetry:main Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants