Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update opentelementry dependencies to 1.0.0/0.26.0 #695

Merged
merged 5 commits into from
Oct 11, 2021

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Oct 11, 2021

I started from the renovate version in #684 and added some comites to adapt to the core API changes and additionally I updated experimental dependencies.

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #695 (ab1a6f9) into main (0e8b359) will decrease coverage by 1.80%.
The diff coverage is 100.00%.

❗ Current head ab1a6f9 differs from pull request most recent head 340483a. Consider uploading reports for the commit 340483a to get more accurate results

@@            Coverage Diff             @@
##             main     #695      +/-   ##
==========================================
- Coverage   96.82%   95.02%   -1.81%     
==========================================
  Files           9      168     +159     
  Lines         630    11975   +11345     
  Branches      124     1119     +995     
==========================================
+ Hits          610    11379   +10769     
- Misses         20      596     +576     
Impacted Files Coverage Δ
...njection/src/instrumentation/WebInstrumentation.ts 97.22% <100.00%> (ø)
...telemetry-instrumentation-net/test/connect.test.ts 96.69% <0.00%> (ø)
...try-instrumentation-graphql/src/instrumentation.ts 92.72% <0.00%> (ø)
.../opentelemetry-instrumentation-graphql/src/enum.ts 100.00% <0.00%> (ø)
...metry-instrumentation-dns/test/utils/assertSpan.ts 100.00% <0.00%> (ø)
...ry-instrumentation-koa/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...emetry-id-generator-aws-xray/src/platform/index.ts 100.00% <0.00%> (ø)
...ode/opentelemetry-instrumentation-hapi/.mocharc.js 60.00% <0.00%> (ø)
...etry-instrumentation-bunyan/src/instrumentation.ts 97.82% <0.00%> (ø)
...de/opentelemetry-instrumentation-hapi/src/types.ts 100.00% <0.00%> (ø)
... and 150 more

@Flarna
Copy link
Member Author

Flarna commented Oct 11, 2021

@open-telemetry/javascript-approvers It would be nice if this could be reviewed and merged soon and included into a release.

The current setup is quite bad for end users. e.g. if you do npm install @opentelemetry/instrumentation-ioredis @opentelemetry/instrumentation-http you get two instances of @opentelemetry/instrumentation and @opentelemetry/core...
This may work in some situations but I guess the risk of unexpected behavior is high. Besides that it's quite inefficient to have modules installed in several versions in parallel.

I think as long as @opentelemetry/instrumentation is experimental we have to keep this repo included in the release train.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.