-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add AWS resource detector ownership #608
Conversation
Codecov Report
@@ Coverage Diff @@
## main #608 +/- ##
==========================================
+ Coverage 94.88% 94.92% +0.03%
==========================================
Files 155 191 +36
Lines 9577 11519 +1942
Branches 862 1109 +247
==========================================
+ Hits 9087 10934 +1847
- Misses 490 585 +95
|
@legendecas looks like you originally authored this package are you ok with ceding ownership to the AWS team? |
I mistakenly thought one of our engineers had contributed this package! Happy to share ownership with @legendecas or figure out something else |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dyladan @willarmiros LGTM with ownership changes!
Actually, I was just moving the packages from opentelemtry-js repo in a very recent PR.
Extending #606