-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cassandra-driver instrumentation #538
Conversation
Codecov Report
@@ Coverage Diff @@
## main #538 +/- ##
==========================================
- Coverage 96.68% 94.58% -2.10%
==========================================
Files 13 156 +143
Lines 634 9702 +9068
Branches 124 1003 +879
==========================================
+ Hits 613 9177 +8564
- Misses 21 525 +504
|
plugins/node/opentelemetry-instrumentation-cassandra/package.json
Outdated
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-cassandra/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-cassandra/src/instrumentation.ts
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-cassandra/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-cassandra/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-cassandra/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
As it's already 3 years old and gradually phased out, perhaps it would make sense to add it once someone explicitly requests it?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtnm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with seemk, there is no urgent need to support old versions unless someone requests it.
Please fix the conflicts and this can be merged
Which problem is this PR solving?
Adds cassandra-driver instrumentation.
Short description of the changes
execute
,batch
,stream
calls.stream
span ends when all of the data has been received.test-utils
.>=4.4 <5.0