Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Explicitly state that express instrumentation does not export spans without http instrumentation #472

Merged
merged 2 commits into from
May 5, 2021
Merged

docs: Explicitly state that express instrumentation does not export spans without http instrumentation #472

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3a7dbb
docs: Explicitly state that express instrumentation does not export s…
svrnm May 5, 2021
d38497c
Merge branch 'main' into patch-1
vmarchaud May 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/node/opentelemetry-instrumentation-express/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ For automatic instrumentation see the

## Installation

This instrumentation relies on HTTP calls to also be instrumented. Make sure you install and enable both.
This instrumentation relies on HTTP calls to also be instrumented. Make sure you install and enable both, otherwise you will not see any spans being exported from the instrumentation.

```bash
npm install --save @opentelemetry/instrumentation-http @opentelemetry/instrumentation-express
Expand Down