Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bunyan instrumentation #419

Merged
merged 11 commits into from
Apr 15, 2021
Merged

Conversation

seemk
Copy link
Contributor

@seemk seemk commented Apr 11, 2021

Which problem is this PR solving?

Adds injection of trace context to bunyan records for improved log correlation as specified by the spec here

I.e. injects trace_id, span_id, trace_flags to bunyan records.

@seemk seemk requested a review from a team April 11, 2021 12:36
@codecov
Copy link

codecov bot commented Apr 11, 2021

Codecov Report

Merging #419 (c8b1bef) into main (09f0a19) will decrease coverage by 2.51%.
The diff coverage is n/a.

❗ Current head c8b1bef differs from pull request most recent head b54ad12. Consider uploading reports for the commit b54ad12 to get more accurate results

@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
- Coverage   98.34%   95.83%   -2.52%     
==========================================
  Files           8       15       +7     
  Lines         363      624     +261     
  Branches       62       94      +32     
==========================================
+ Hits          357      598     +241     
- Misses          6       26      +20     
Impacted Files Coverage Δ
...ackages/opentelemetry-host-metrics/src/stats/si.ts 66.66% <0.00%> (ø)
packages/opentelemetry-host-metrics/src/version.ts 100.00% <0.00%> (ø)
packages/opentelemetry-host-metrics/src/metric.ts 100.00% <0.00%> (ø)
...ages/opentelemetry-host-metrics/src/BaseMetrics.ts 57.57% <0.00%> (ø)
...ges/opentelemetry-host-metrics/test/metric.test.ts 96.52% <0.00%> (ø)
...ges/opentelemetry-host-metrics/src/stats/common.ts 100.00% <0.00%> (ø)
packages/opentelemetry-host-metrics/src/enum.ts 100.00% <0.00%> (ø)

Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@obecny obecny added the enhancement New feature or request label Apr 15, 2021
@vmarchaud vmarchaud merged commit 2dceaf3 into open-telemetry:main Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants