-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fixing context propagation on mongo callback #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmarchaud
approved these changes
Mar 31, 2021
Codecov Report
@@ Coverage Diff @@
## main #403 +/- ##
==========================================
- Coverage 94.43% 94.21% -0.22%
==========================================
Files 11 12 +1
Lines 431 432 +1
Branches 48 48
==========================================
Hits 407 407
- Misses 24 25 +1
|
dyladan
approved these changes
Apr 5, 2021
jtmalinowski
reviewed
Apr 6, 2021
jtmalinowski
reviewed
Apr 6, 2021
plugins/node/opentelemetry-instrumentation-mongodb/test/mongodb.test.ts
Outdated
Show resolved
Hide resolved
jtmalinowski
reviewed
Apr 6, 2021
plugins/node/opentelemetry-instrumentation-mongodb/package.json
Outdated
Show resolved
Hide resolved
cc @jtmalinowski i believe your comments were addressed, are you okay to merge it ? |
jtmalinowski
approved these changes
Apr 8, 2021
obecny
added a commit
to obecny/opentelemetry-js-contrib
that referenced
this pull request
Apr 15, 2021
Co-authored-by: Valentin Marchaud <thisismac47@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes