fix: net instrumentation - change span kind of connect to internal #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flarna
reviewed
Mar 23, 2021
| @@ -92,7 +92,7 @@ export class NetInstrumentation extends InstrumentationBase<Net> { | |||
| /* It might still be useful to pick up errors due to invalid connect arguments. */ | |||
| private _startGenericSpan(socket: Socket) { | |||
| const span = this.tracer.startSpan('connect', { | |||
| kind: SpanKind.CLIENT, | |||
| kind: SpanKind.INTERNAL, | |||
There was a problem hiding this comment.
SpanKind.INTERNAL is the default so you could omit the second argument.
There was a problem hiding this comment.
Thanks, good point 🙂 Fixed it
Flarna
approved these changes
Mar 23, 2021
Codecov Report
@@ Coverage Diff @@
## main #394 +/- ##
=======================================
Coverage 94.43% 94.43%
=======================================
Files 11 11
Lines 431 431
Branches 48 48
=======================================
Hits 407 407
Misses 24 24 |
dyladan
approved these changes
Mar 23, 2021
vmarchaud
approved these changes
Mar 24, 2021
dyladan
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
From the spec:
CLIENTIndicates that the span describes a synchronous request to some remote service. This span is the parent of a remote SERVER span and waits for its response.However there is no corresponding server span for
connect. Thus I think the least spec violating span kind forconnectshould beINTERNAL.Short description of the changes
Change span kind of
connectfromCLIENTtoINTERNAL.