Update GraphQL README to note setTracerProvider is optional
#293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onal This caused me some confusion because they node-sdk doesn't give me a tracer provider to pass in here. But it turned out I don't have to call this at all.
dobesv
changed the title
setTracerProvider is opti…setTracerProvider is optional
Codecov Report
@@ Coverage Diff @@
## master #293 +/- ##
=======================================
Coverage 95.32% 95.32%
=======================================
Files 115 115
Lines 5948 5948
Branches 586 586
=======================================
Hits 5670 5670
Misses 278 278 |
vmarchaud
approved these changes
Dec 24, 2020
obecny
approved these changes
Dec 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused me some confusion because they node-sdk doesn't give me a tracer provider to pass in here. But it turned out I don't have to call this at all.