Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactoring host metrics, aligning with semantic conventions #266

Merged
merged 7 commits into from
Dec 11, 2020

Conversation

obecny
Copy link
Member

@obecny obecny commented Nov 20, 2020

Refactoring host metrics

  1. Updating semantic conventions
  2. Fixing metrics and aligning metric types
  3. Created base class to be extended to runtime metrics

@obecny obecny requested a review from a team November 20, 2020 22:59
@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #266 (fe6bfc4) into master (4ed223b) will decrease coverage by 0.12%.
The diff coverage is 91.42%.

@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
- Coverage   95.07%   94.94%   -0.13%     
==========================================
  Files         110      110              
  Lines        5888     5937      +49     
  Branches      609      617       +8     
==========================================
+ Hits         5598     5637      +39     
- Misses        290      300      +10     
Impacted Files Coverage Δ
...ackages/opentelemetry-host-metrics/src/stats/si.ts 66.66% <50.00%> (-22.23%) ⬇️
...ages/opentelemetry-host-metrics/src/BaseMetrics.ts 56.25% <56.25%> (ø)
packages/opentelemetry-host-metrics/src/enum.ts 100.00% <100.00%> (ø)
packages/opentelemetry-host-metrics/src/metric.ts 100.00% <100.00%> (+5.19%) ⬆️
...ges/opentelemetry-host-metrics/src/stats/common.ts 100.00% <100.00%> (ø)
...ges/opentelemetry-host-metrics/test/metric.test.ts 96.52% <100.00%> (+1.01%) ⬆️
packages/opentelemetry-host-metrics/src/util.ts

Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, quick question though: in the doc you state that it collect CPU, Memory, Heap, Network, Event Loop, Garbage Collector, Heap Space but i dont see any code to retrieve event loop nor GC / Heap space metrics, i guess there will comes later on ?

EDIT: Linter need to be fixed before merge

Copy link
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@obecny obecny self-assigned this Dec 8, 2020
@obecny
Copy link
Member Author

obecny commented Dec 10, 2020

lgtm, quick question though: in the doc you state that it collect CPU, Memory, Heap, Network, Event Loop, Garbage Collector, Heap Space but i dont see any code to retrieve event loop nor GC / Heap space metrics, i guess there will comes later on ?

EDIT: Linter need to be fixed before merge

fixed

@obecny obecny merged commit f039f1f into open-telemetry:master Dec 11, 2020
@obecny obecny deleted the metrics-host branch December 11, 2020 15:40
@obecny obecny added the enhancement New feature or request label Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants