-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactoring host metrics, aligning with semantic conventions #266
Conversation
Codecov Report
@@ Coverage Diff @@
## master #266 +/- ##
==========================================
- Coverage 95.07% 94.94% -0.13%
==========================================
Files 110 110
Lines 5888 5937 +49
Branches 609 617 +8
==========================================
+ Hits 5598 5637 +39
- Misses 290 300 +10
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, quick question though: in the doc you state that it collect CPU, Memory, Heap, Network, Event Loop, Garbage Collector, Heap Space
but i dont see any code to retrieve event loop nor GC / Heap space metrics, i guess there will comes later on ?
EDIT: Linter need to be fixed before merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fixed |
Refactoring host metrics