fix: add missing @opentelemetry/core dependency #2473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryliag
approved these changes
Oct 10, 2024
pichlermarc
commented
Oct 10, 2024
| @@ -73,8 +73,9 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@opentelemetry/instrumentation": "^0.53.0", | |||
| "@opentelemetry/semantic-conventions": "^1.27.0", | |||
| "@opentelemetry/semantic-conventions": "1.27.0", | |||
There was a problem hiding this comment.
drive-by-fix: we're using the @opentelemetry/semantic-conventions/incubating entrypoint which may break in minor versions - pinning this to avoid any surprises when we release the 1.28.0.
There was a problem hiding this comment.
Might want the same at
We should have a lint check for this perhaps.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2473 +/- ##
=======================================
Coverage 90.74% 90.74%
=======================================
Files 156 156
Lines 7723 7723
Branches 1588 1588
=======================================
Hits 7008 7008
Misses 715 715 |
trentm
approved these changes
Oct 10, 2024
Merged
trentm
added a commit
to trentm/opentelemetry-js-contrib
that referenced
this pull request
Oct 10, 2024
This uses knip (https://knip.dev) to check dependencies, in hopes of avoiding issues like open-telemetry#2473. This adds 'npm run lint:deps' and adds that to the existing 'npm run lint'. This change includes fixes for a handful of unused and unlisted deps. For now knip is configured to only check 'production' deps. Checking non-prod deps results in way too many false positives.
trentm
added a commit
that referenced
this pull request
Oct 24, 2024
…2477) This uses knip (https://knip.dev) to check dependencies, in hopes of avoiding issues like #2473. This adds 'npm run lint:deps' and adds that to the existing 'npm run lint'. This change includes fixes for a handful of unused and unlisted deps. For now knip is configured to only check 'production' deps. Checking non-prod deps results in way too many false positives. Note that knip is being run via `npx` rather than installing as a devDep because there is a conflict: knip deps on typescript@5 and all packaegs in this repo currently use typescript@4.4.4. Installing knip at the top-level results in a ballooning of the node_modules install size as typescript@4.4.4 is installed 40+ types in all separate workspaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
See #2472, we're using
@opentelemetry/corebut don't have it listed as a dependency in some packages.Short description of the changes
@opentelemetry/semantic-conventionsdependency for@opentelemetry/instrumentation-pgas it's using theincubatingentrypoint, which may break on minor bumps.