Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(instr-runtime-node): update some deps to same versions as other contrib packages #1994

Merged

Conversation

trentm
Copy link
Contributor

@trentm trentm commented Mar 5, 2024

  • reduce 'mocha' dep to v7 used by all other packages
  • bump /api peer dep to 1.3.0 (the version when api-metrics was merged into api)

This replaces #1967. Because this package has moved to a new name (used to be instrumentation-perf-tools), it was easier to start with a fresh PR. This also takes into consideration Marc's feedback at #1967 (comment)

… contrib packages

- reduce 'mocha' dep to v7 used by all other packages
- bump /api peer dep to 1.3.0 (the version when api-metrics was merged into api)
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Merging #1994 (5041a0a) into main (7106313) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1994   +/-   ##
=======================================
  Coverage   91.03%   91.03%           
=======================================
  Files         146      146           
  Lines        7492     7492           
  Branches     1501     1501           
=======================================
  Hits         6820     6820           
  Misses        672      672           

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@pichlermarc pichlermarc merged commit d2f59e9 into open-telemetry:main Mar 6, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants