Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: align @types/node version to core and disable it in renovate #1653

Merged
merged 6 commits into from
Aug 30, 2023

Conversation

blumamir
Copy link
Member

@blumamir blumamir commented Aug 28, 2023

This PR replaces: #1617.

It pins the version of "@types/node" across the repo to use a single version - 18.6.5, the one we are currently using in core repo, and disables renovate from creating PRs to bump the version.

We don't want to depend on newer features of node by accident. See also: open-telemetry/opentelemetry-js#4091

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #1653 (f3b3473) into main (0b1f5b6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1653   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files         139      139           
  Lines        7112     7112           
  Branches     1427     1427           
=======================================
  Hits         6527     6527           
  Misses        585      585           

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thanks for taking care of this. 🙂

@blumamir blumamir merged commit 78472a7 into open-telemetry:main Aug 30, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.