Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: re-enable instrumentation-fastify unit test on node@18 #1568

Merged

Conversation

chigia001
Copy link
Contributor

Which problem is this PR solving?

  • I test multiple time on my local node@18 and instrumentation-fastify seem working fine with node@18, so we might want to enable this test again.

Short description of the changes

  • remove instrumentation-fastify from the ignore list of node@18 unit test

@chigia001 chigia001 requested a review from a team July 12, 2023 06:17
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #1568 (968bcda) into main (84a2377) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1568   +/-   ##
=======================================
  Coverage   96.06%   96.06%           
=======================================
  Files          14       14           
  Lines         914      914           
  Branches      199      199           
=======================================
  Hits          878      878           
  Misses         36       36           

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙂

@pichlermarc pichlermarc merged commit 273993b into open-telemetry:main Jul 12, 2023
13 checks passed
@chigia001 chigia001 deleted the chore-enable-fastify-node-18-test branch July 12, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants