feat: adding Koa instrumentation #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
==========================================
+ Coverage 94.31% 94.61% +0.29%
==========================================
Files 77 84 +7
Lines 3836 4124 +288
Branches 415 432 +17
==========================================
+ Hits 3618 3902 +284
- Misses 218 222 +4
|
chore: add tslint chore: add standard license chore: add npmignore chore: initial package config docs: initial README chore: create initial structure chore: adds traces to Application.use method itself (on instantiation) feat: traces for app.use chore: update typescript version chore: return original layer result chore: remove app.use span based on design chore: refactor span attribute assignments into util chore: add router types feat: added tracing for koa-router functions and routes feat: don't create koa spans without root span feat: added base tests for Koa core and Koa router chore: finalizing plugin feat: added kLayerPatched check test: creating example code for Koa plugin chore: cleaning up code chore: update README chore: update README chore: update README chore: add async middleware tests chore: improve sample code Add files via upload Add files via upload Add files via upload chore: add jaeger example Add files via upload chore: add linter to example code chore: rename plugin to instrumentation chore: cleaning tests/examples Add files via upload Add files via upload chore: fix async example code and span timing chore: refine test style docs: add comments to plugin patching operations chore: file cleanup chore: fix code style
Closed
dyladan
reviewed
Jul 17, 2020
vmarchaud
reviewed
Jul 18, 2020
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
markwolff
reviewed
Jul 20, 2020
markwolff
reviewed
Jul 20, 2020
markwolff
reviewed
Jul 20, 2020
vmarchaud
reviewed
Jul 27, 2020
vmarchaud
approved these changes
Jul 27, 2020
markwolff
approved these changes
Jul 27, 2020
carolinee21
changed the title
dyladan
approved these changes
Jul 29, 2020
michaelgoin
reviewed
Jul 29, 2020
michaelgoin
approved these changes
Jul 31, 2020
dyladan
requested changes
Aug 5, 2020
dyladan
reviewed
Aug 5, 2020
michaelgoin
reviewed
Aug 6, 2020
|
@dyladan @obecny @michaelgoin Now that the other PR has been merged, this one is unblocked and should be ready to go! |
@dyladan requested changes, wait for him to approve first |
|
@dyladan Hi Daniel! Please let me know if there's anything else missing from me on this or the Hapi PR. Thanks! :) |
dyladan
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
This instrumentation adds traces to middleware for both the Koa core and Koa Router modules.
Some example traces are shown here:
User friendly example code is also added under examples/koa