-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(propagator/aws-xray): Extract X-Ray header in a case-insensitive fashion #1328
Merged
Merged
Changes from 7 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
0a22bb7
Extract X-Ray header in a case-insensitive fashion
NPellet 20dc669
Back to apostrophes
NPellet af5447c
Switch to 1 tab = 2 spaces
NPellet 451f626
Add semis
NPellet eec8069
Apply prettier to tests as well
NPellet 18368ff
Merge branch 'main' into x_ray_case_insensitive
NPellet 2a4dee4
Merge branch 'main' into x_ray_case_insensitive
NPellet dffa593
Merge branch 'main' into x_ray_case_insensitive
NPellet 42936cc
Merge branch 'main' into x_ray_case_insensitive
blumamir 90e35fe
Merge branch 'main' into x_ray_case_insensitive
blumamir f1b2098
Merge branch 'main' into x_ray_case_insensitive
dyladan e00ec7d
Merge branch 'main' into x_ray_case_insensitive
blumamir 2269587
chore: fix lint
blumamir 2c94b0c
Merge branch 'main' into x_ray_case_insensitive
blumamir 85ce208
Merge branch 'main' into x_ray_case_insensitive
blumamir 7223439
Merge branch 'main' into x_ray_case_insensitive
blumamir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's better to implement that logic in a new proprietary TextMapGetter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@osherv I don't think that's advisable.
If, as a platform engineer, I use the SDK to register an AWS XRay propagator, or a B3 propagator, that's my problem. It should be invisible to the API consumer.
The developer who then uses the API to extract or inject the context should only concern himself with the serialisation/deserialisation of the context into/from the payload. It should not be concerned whether or not the propagator is expecting a lowercase string or not. It can't know if the expected key should be lower case, upper case, camel-case, kebab-case, etc. That's the responsibly of the propagator.
If you stand your point, then the AWS Lambda instrumentation has to be modified to use case-independent header keys, because at the moment, using both appears to be incompatible.