Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use GA version of metrics #1281

Merged
merged 5 commits into from
Nov 16, 2022
Merged

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Nov 11, 2022

Update host-metrics to use the GA version of metrics SDK and no longer use api-metrics.

Remove metrics packages from experimental OTel renovate config.

Update host-metrics to use the GA version of metrics SDK and no longer use api-metrics.

Remove metrics packages from experimental OTel renovate config.
@Flarna
Copy link
Member Author

Flarna commented Nov 11, 2022

seems this requires #1278 or #1279 to be merged first because of lerna hoisting.

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #1281 (c60100a) into main (d39595a) will increase coverage by 1.99%.
The diff coverage is 100.00%.

❗ Current head c60100a differs from pull request most recent head f88a25a. Consider uploading reports for the commit f88a25a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1281      +/-   ##
==========================================
+ Coverage   96.08%   98.07%   +1.99%     
==========================================
  Files          14        6       -8     
  Lines         893      156     -737     
  Branches      191       10     -181     
==========================================
- Hits          858      153     -705     
+ Misses         35        3      -32     
Impacted Files Coverage Δ
packages/opentelemetry-host-metrics/src/metric.ts 100.00% <ø> (ø)
...ages/opentelemetry-host-metrics/src/BaseMetrics.ts 100.00% <100.00%> (ø)
...emetry-propagator-instana/src/InstanaPropagator.ts
...entation-document-load/src/enums/AttributeNames.ts
...etapackages/auto-instrumentations-web/src/utils.ts
...trumentation-document-load/src/enums/EventNames.ts
...lemetry-instrumentation-document-load/src/utils.ts
...y-instrumentation-long-task/src/instrumentation.ts
...metry-propagator-ot-trace/src/OTTracePropagator.ts
...lugin-react-load/src/BaseOpenTelemetryComponent.ts
... and 12 more

packages/opentelemetry-host-metrics/test/metric.test.ts Outdated Show resolved Hide resolved
packages/opentelemetry-host-metrics/package.json Outdated Show resolved Hide resolved
@dyladan dyladan merged commit 7f02de2 into open-telemetry:main Nov 16, 2022
@dyladan dyladan mentioned this pull request Nov 16, 2022
@Flarna Flarna deleted the metrics-ga branch November 16, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants