Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update experimental Otel deps to ^0.32.0 #1143

Merged
merged 4 commits into from
Sep 2, 2022

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Aug 31, 2022

Which problem is this PR solving?

Avoid duplicates of e.g. @opentelemetry/instrumentation.

Short description of the changes

Depend on ^0.32.0 for experimental OTel packages because ^0.31.0 doesn't pick up 0.32.x.
This avoids duplicates of e.g. @opentelemetry/instrumentation in case latest is requested via app package.json.

Additionally use sdk-metrics instead sdk-metrics-base as it was renamed in core repo.

Checklist

  • Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

Depend on ^0.32.0 for experimental OTel packages because ^0.31.0 doesn't pick up 0.32.x.
This avoids duplicates of e.g. @opentelemetry/instrumentation in case latest is requested via
app package.json.
@Flarna Flarna requested a review from a team August 31, 2022 19:08
@Flarna Flarna changed the title Otel experimental 0.32 feat: update experimental Otel deps to ^0.32.0 Aug 31, 2022
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #1143 (af375ee) into main (078ab2d) will decrease coverage by 4.03%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1143      +/-   ##
==========================================
- Coverage   96.07%   92.04%   -4.04%     
==========================================
  Files          14      121     +107     
  Lines         892     6006    +5114     
  Branches      191     1182     +991     
==========================================
+ Hits          857     5528    +4671     
- Misses         35      478     +443     
Impacted Files Coverage Δ
...ages/opentelemetry-host-metrics/src/BaseMetrics.ts 100.00% <ø> (ø)
...e/opentelemetry-instrumentation-redis/src/utils.ts 93.10% <0.00%> (ø)
...lemetry-instrumentation-net/src/instrumentation.ts 98.07% <0.00%> (ø)
...opentelemetry-instrumentation-aws-sdk/src/enums.ts 100.00% <0.00%> (ø)
...detector-aws/src/detectors/AwsBeanstalkDetector.ts 95.65% <0.00%> (ø)
...de/opentelemetry-instrumentation-hapi/src/types.ts 100.00% <0.00%> (ø)
...metry-resource-detector-aws/src/detectors/index.ts 100.00% <0.00%> (ø)
...ode/opentelemetry-instrumentation-net/src/types.ts 100.00% <0.00%> (ø)
...try-instrumentation-restify/src/instrumentation.ts 89.32% <0.00%> (ø)
...ode/instrumentation-tedious/src/instrumentation.ts 92.47% <0.00%> (ø)
... and 98 more

@Flarna Flarna mentioned this pull request Sep 1, 2022
@dyladan dyladan merged commit 6fb1911 into open-telemetry:main Sep 2, 2022
@Flarna Flarna deleted the otel-experimental-0.32 branch September 2, 2022 13:29
@dyladan dyladan mentioned this pull request Jan 2, 2023
@dyladan dyladan mentioned this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants