-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update experimental Otel deps to ^0.32.0 #1143
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depend on ^0.32.0 for experimental OTel packages because ^0.31.0 doesn't pick up 0.32.x. This avoids duplicates of e.g. @opentelemetry/instrumentation in case latest is requested via app package.json.
github-actions
bot
assigned blumamir, legendecas, naseemkullah, NathanielRN, obecny, rauno56 and willarmiros
Aug 31, 2022
Flarna
changed the title
Otel experimental 0.32
feat: update experimental Otel deps to ^0.32.0
Aug 31, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1143 +/- ##
==========================================
- Coverage 96.07% 92.04% -4.04%
==========================================
Files 14 121 +107
Lines 892 6006 +5114
Branches 191 1182 +991
==========================================
+ Hits 857 5528 +4671
- Misses 35 478 +443
|
Merged
dyladan
approved these changes
Sep 1, 2022
legendecas
approved these changes
Sep 2, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Avoid duplicates of e.g.
@opentelemetry/instrumentation
.Short description of the changes
Depend on
^0.32.0
for experimental OTel packages because^0.31.0
doesn't pick up0.32.x
.This avoids duplicates of e.g.
@opentelemetry/instrumentation
in case latest is requested via app package.json.Additionally use
sdk-metrics
insteadsdk-metrics-base
as it was renamed in core repo.Checklist
npm run test-all-versions
for the edited package(s) on the latest commit if applicable.