-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(memcached): low cardinality span name #1104
Merged
dyladan
merged 2 commits into
open-telemetry:main
from
aadharsh-rengarajan:span-name-change
Aug 10, 2022
Merged
fix(memcached): low cardinality span name #1104
dyladan
merged 2 commits into
open-telemetry:main
from
aadharsh-rengarajan:span-name-change
Aug 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
aadharsh-rengarajan
changed the title
Clean span name in memcached instrumentation
fix: clean span name in memcached instrumentation
Aug 1, 2022
aadharsh-rengarajan
force-pushed
the
span-name-change
branch
2 times, most recently
from
August 1, 2022 14:40
4d37bc6
to
cbe323e
Compare
vmarchaud
approved these changes
Aug 2, 2022
Codecov Report
@@ Coverage Diff @@
## main #1104 +/- ##
==========================================
- Coverage 96.07% 95.95% -0.12%
==========================================
Files 14 17 +3
Lines 892 1014 +122
Branches 191 210 +19
==========================================
+ Hits 857 973 +116
- Misses 35 41 +6
|
blumamir
reviewed
Aug 10, 2022
plugins/node/opentelemetry-instrumentation-memcached/src/instrumentation.ts
Show resolved
Hide resolved
blumamir
changed the title
fix: clean span name in memcached instrumentation
fix(memcached): low cardinality span name
Aug 10, 2022
aadharsh-rengarajan
force-pushed
the
span-name-change
branch
from
August 10, 2022 14:40
468b982
to
a4e987a
Compare
aadharsh-rengarajan
force-pushed
the
span-name-change
branch
from
August 10, 2022 14:44
a4e987a
to
67d43f7
Compare
dyladan
approved these changes
Aug 10, 2022
dyladan
reviewed
Aug 10, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
We have addressed the problem above by making the changes necessary and we can get the memcached value from the span attributes itself.
Short description of the changes
Checklist
npm test
for the edited package(s) on the latest commit if applicable.