Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-sdk): set spanKind to CLIENT by default in v3 #1177

Merged
merged 10 commits into from
Sep 21, 2022

Conversation

haddasbronfman
Copy link
Member

Which problem is this PR solving?

This: #1128

Short description of the changes

set spanKind to be CLIENT when initializing a span in v3

Checklist

  • [ V] Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #1177 (7f58ca6) into main (35d1e45) will increase coverage by 0.53%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1177      +/-   ##
==========================================
+ Coverage   96.07%   96.61%   +0.53%     
==========================================
  Files          14       25      +11     
  Lines         892     1447     +555     
  Branches      191      309     +118     
==========================================
+ Hits          857     1398     +541     
- Misses         35       49      +14     
Impacted Files Coverage Δ
...entelemetry-instrumentation-aws-sdk/src/aws-sdk.ts 97.45% <100.00%> (ø)
...entation-aws-sdk/src/services/MessageAttributes.ts 91.89% <0.00%> (ø)
...etry-instrumentation-aws-sdk/src/services/index.ts 100.00% <0.00%> (ø)
...opentelemetry-instrumentation-aws-sdk/src/utils.ts 97.29% <0.00%> (ø)
...try-instrumentation-aws-sdk/src/services/lambda.ts 97.77% <0.00%> (ø)
...y-instrumentation-aws-sdk/src/services/dynamodb.ts 100.00% <0.00%> (ø)
...emetry-instrumentation-aws-sdk/src/services/sqs.ts 100.00% <0.00%> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts 98.00% <0.00%> (ø)
...opentelemetry-instrumentation-aws-sdk/src/enums.ts 100.00% <0.00%> (ø)
... and 2 more

Copy link
Member

@blumamir blumamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@blumamir blumamir merged commit d463695 into open-telemetry:main Sep 21, 2022
@haddasbronfman haddasbronfman deleted the aws-span-kind branch September 21, 2022 10:17
@dyladan dyladan mentioned this pull request Sep 21, 2022
@dyladan dyladan mentioned this pull request Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants