-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-sdk instrumentation is definining span.kind as internal #1128
Comments
Can you assign this to me please? |
@mentos1386 Hi, I tried to reproduce your issue by instrumenting dynamodb.listTables() and s3.listBuckets() and both of them created spans with spanKind:2 (CLIENT). |
@haddasbronfman I am using aws sdk v3. We are also using the following options: suppressInternalInstrumentation: true, If you can't reproduce with aws sdk v3, i can try to create a working repo. |
I couldn't reproduce although I used
|
Hi @mentos1386, can you supply a working example? |
Thanks to @blumamir I managed to reproduce the issue. I'll fix it. |
@mentos1386 bug fixed. you can close the issue. |
What version of OpenTelemetry are you using?
What version of Node are you using?
v16
What did you do?
Using
@opentelemetry/instrumentation-aws-sdk
to instrument our aws sdk requests.What did you expect to see?
Requests to all AWS Services should have
span.kind
asclient
. Except for SNS/SQS where this is handled correctly.What did you see instead?
span.kind
is set asinternal
(the default value).The text was updated successfully, but these errors were encountered: