Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Web based karma tests are no longer running #1135

Closed
MSNev opened this issue Aug 30, 2022 · 6 comments · Fixed by #1137
Closed

[Bug] Web based karma tests are no longer running #1135

MSNev opened this issue Aug 30, 2022 · 6 comments · Fixed by #1137
Assignees
Labels
bug Something isn't working

Comments

@MSNev
Copy link
Contributor

MSNev commented Aug 30, 2022

What version of OpenTelemetry are you using?

Current rebase of the contribu repo

What version of Node are you using?

16.14.0

What did you do?

  • clean fetch of repo
  • npm install
  • npm run install
  • Go into the plugins/web/opentelemetry-instrumentation-document-load
  • npm run test

What did you expect to see?

  • passing tests

What did you see instead?

  • failing tests
@MSNev MSNev added the bug Something isn't working label Aug 30, 2022
@dyladan
Copy link
Member

dyladan commented Aug 30, 2022

@MSNev if you have it handy can you post the failure? If not i'll just run it myself

@MSNev MSNev self-assigned this Aug 30, 2022
MSNev added a commit to MSNev/opentelemetry-js-contrib that referenced this issue Aug 30, 2022
…1135

ci: [Bug] DNS Lookup and Promise Lookup test for error NOT_FOUND failing open-telemetry#1136
MSNev added a commit to MSNev/opentelemetry-js-contrib that referenced this issue Aug 30, 2022
@MSNev
Copy link
Contributor Author

MSNev commented Aug 30, 2022

D:\MSNev1\opentelemetry-js-contrib\plugins\web\opentelemetry-instrumentation-document-load>npm run test:browser

> @opentelemetry/instrumentation-document-load@0.29.0 test:browser
> nyc karma start --single-run

Webpack bundling...
Error: EINVAL: invalid argument, mkdir 'C:\Users\newylie\AppData\Local\Temp\_karma_webpack_341915\D:\MSNev1\opentelemetry-js-contrib\plugins\web\opentelemetry-instrumentation-document-load\build\src'

The normal documented way to avoid this issue is to set the webpack

optimization: {
    runtimeChunk: false,
    splitChunks: false
}

However, these options did not work for the contrib repo

@dyladan
Copy link
Member

dyladan commented Aug 30, 2022

Is that a windows-specific issue? I ask because it didn't get caught during the initial PR to update to webpack 5. It's a bummer that we have to roll back to a previous testing version just for a single plugin.

@MSNev
Copy link
Contributor Author

MSNev commented Aug 30, 2022

No it's not, it's just a little more obvious because of the drive letter embedded in the resulting path that it uses to understand what is going on.

codymikol/karma-webpack#489

And in the contrib repo #1129 also hit it on a non-windows box #1129 (comment)

@dyladan
Copy link
Member

dyladan commented Aug 30, 2022

Interesting. That looks really similar to an error I was having on macos with temp directories in the main repo with webpack 5. any idea why this has taken so long to be a problem?

@MSNev
Copy link
Contributor Author

MSNev commented Aug 30, 2022

I think it's environmental, the main tests on GitHub seem to be passing. So it's really just as people start contributing their setup's (including mine) have issues with the defaults.

vmarchaud added a commit that referenced this issue Sep 10, 2022
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Co-authored-by: Valentin Marchaud <contact@vmarchaud.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants