Skip to content

Commit

Permalink
Added excluded rules and fixed warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
Yosef Arbiv committed Nov 7, 2021
1 parent 9bcec15 commit 6a1afe7
Show file tree
Hide file tree
Showing 39 changed files with 312 additions and 253 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,5 @@ jobs:
- name: Lint markdown files
uses: avto-dev/markdown-lint@v1
with:
ignore: "./**/CHANGELOG.md ./**/node_modules/**"
ignore: "./**/CHANGELOG.md"
args: "./**/*.md"
6 changes: 6 additions & 0 deletions .markdownlint.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"MD013": false,
"MD024": false,
"MD033": false,
"MD041": false
}
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -114,11 +114,13 @@ Node.JS `v8` | See [Node Support](#node-support) below
Web Browsers | ✅ See [Browser Support](#browser-support) below

### Node Support

Automated tests are run using the latest release of each currently active version of Node.JS.
While Node.JS v8 is no longer supported by the Node.JS team, the latest version of Node.JS v8 is still included in our testing suite.
Please note that versions of Node.JS v8 prior to `v8.5.0` will NOT work, because OpenTelemetry Node depends on the `perf_hooks` module introduced in `v8.5.0`

### Browser Support

Automated browser tests are run in the latest version of Headless Chrome.
There is currently no list of officially supported browsers, but OpenTelemetry is developed using standard web technologies with wide support and should work in currently supported versions of major browsers.

Expand Down
11 changes: 8 additions & 3 deletions RELEASING.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
This repository uses [Release Please](https://github.com/googleapis/release-please) to manage its releases automatically and independently.
Modified packages are automatically published to NPM when the auto-generated Release Please PR is merged.

# Manual Publishing Process
## Manual Publishing Process

For posterity, or in the event of any failures with release-please, the process for performing a manual release is below.

Expand Down Expand Up @@ -42,13 +42,16 @@ Decide on the next `major.minor.patch` release number based on [semver](http://s
Since we use `lerna`, we can use [lerna-changelog](https://github.com/lerna/lerna-changelog#lerna-changelog)

#### How to use

Pass your [github token](https://help.github.com/en/articles/creating-a-personal-access-token-for-the-command-line) to generate the changelog automatically.
For security reasons, when you create a Github token, select the permissions: under **repo**, select **Access public repositories**, **commit status**.

In your terminal, execute the following command:

```bash
GITHUB_AUTH=<your token> lerna-changelog
```

It will print something like:

```md
Expand All @@ -64,10 +67,12 @@ It will print something like:
- Helpful Hacker ([@helpful-hacker](https://github.com/helpful-hacker))
- [@careful-coder](https://github.com/careful-coder)
```

By default lerna-changelog will show all pull requests that have been merged since the latest tagged commit in the repository. That is however only true for pull requests **with certain labels applied** (see [lerna.json](lerna.json) for authorized labels).

You can also use the `--from` and `--to` options to view a different range of pull requests:
```

```text
GITHUB_AUTH=xxxxx lerna-changelog --from=v1.0.0 --to=v2.0.0
```

Expand Down Expand Up @@ -102,6 +107,7 @@ done
Check your e-mail and make sure the number of “you’ve published this module” emails matches the number you expect.

## Publish the GitHub Release

Publish the GitHub release, ensuring that the tag points to the newly landed commit corresponding to release proposal `x.y.z`.

## Update CHANGELOG
Expand All @@ -110,7 +116,6 @@ Publish the GitHub release, ensuring that the tag points to the newly landed com
* Create a new commit with the exact title: `Post Release: update CHANGELOG.md`.
* Go through PR review and merge it to GitHub main branch.


## Known Issues

* The `examples/` and `getting-started/` folders are not part of lerna packages, we need to manually bump the version in `package.json`.
15 changes: 9 additions & 6 deletions examples/connect/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
OpenTelemetry Connect Instrumentation allows the user to automatically collect trace data and export them to the backend of choice (Collector Exporter), to give observability to distributed systems.

This is a simple example that demonstrates tracing calls made to Connect API. The example shows key aspects of tracing such as

- Root Span (on Client)
- Child Span (on Client)
- Span Events
Expand All @@ -11,15 +12,15 @@ This is a simple example that demonstrates tracing calls made to Connect API. Th
## Installation

```sh
$ # from this directory
$ npm install
# from this directory
npm install
```

## Run the Application

### Collector - docker container

- Run docker container with collector
- Run docker container with collector

```sh
# from this directory
Expand All @@ -28,26 +29,28 @@ $ npm install

### Server

- Run the server
- Run the server

```sh
# from this directory
$ npm run server
```

- Run the client
- Run the client

```sh
# from this directory
npm run client
```

#### Zipkin UI
Go to Zipkin with your browser [http://localhost:9411/]()

Go to Zipkin with your browser <http://localhost:9411/>

<p align="center"><img src="images/trace1.png?raw=true"/></p>

## Useful links

- For more information on OpenTelemetry, visit: <https://opentelemetry.io/>
- For more information on OpenTelemetry for Node.js, visit: <https://github.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-node>

Expand Down
16 changes: 8 additions & 8 deletions examples/dns/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ shows key aspects of tracing such as
## Installation

```sh
$ # from this directory
$ npm install
# from this directory
npm install
```

Setup [Zipkin Tracing](https://zipkin.io/pages/quickstart.html)
Expand All @@ -27,14 +27,14 @@ Setup [Jaeger Tracing](https://www.jaegertracing.io/docs/latest/getting-started/
- Run the client

```sh
$ # from this directory
$ npm run zipkin:client
# from this directory
npm run zipkin:client
```

#### Zipkin UI

`zipkin:client` script should output the `traceid` in the terminal (e.g `traceid: 4815c3d576d930189725f1f1d1bdfcc6`).
Go to Zipkin with your browser [http://localhost:9411/zipkin/traces/(your-trace-id)]() (e.g http://localhost:9411/zipkin/traces/4815c3d576d930189725f1f1d1bdfcc6)
Go to Zipkin with your browser <http://localhost:9411/zipkin/traces/(your-trace-id)> (e.g <http://localhost:9411/zipkin/traces/4815c3d576d930189725f1f1d1bdfcc6>)

<p align="center"><img src="./images/zipkin-ui.png?raw=true"/></p>

Expand All @@ -43,14 +43,14 @@ Go to Zipkin with your browser [http://localhost:9411/zipkin/traces/(your-trace-
- Run the client

```sh
$ # from this directory
$ npm run jaeger:client
# from this directory
npm run jaeger:client
```

#### Jaeger UI

`jaeger:client` script should output the `traceid` in the terminal (e.g `traceid: 4815c3d576d930189725f1f1d1bdfcc6`).
Go to Jaeger with your browser [http://localhost:16686/trace/(your-trace-id)]() (e.g http://localhost:16686/trace/4815c3d576d930189725f1f1d1bdfcc6)
Go to Jaeger with your browser <http://localhost:16686/trace/(your-trace-id)> (e.g <http://localhost:16686/trace/4815c3d576d930189725f1f1d1bdfcc6>)

<p align="center"><img src="images/jaeger-ui.png?raw=true"/></p>

Expand Down
19 changes: 11 additions & 8 deletions examples/express/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ OpenTelemetry Express Instrumentation allows the user to automatically collect t

This is a simple example that demonstrates tracing calls made to Express API. The example
shows key aspects of tracing such as

- Root Span (on Client)
- Child Span (on Client)
- Span Events
Expand All @@ -12,8 +13,8 @@ shows key aspects of tracing such as
## Installation

```sh
$ # from this directory
$ npm install
# from this directory
npm install
```

Setup [Zipkin Tracing](https://zipkin.io/pages/quickstart.html)
Expand All @@ -24,36 +25,37 @@ Setup [Jaeger Tracing](https://www.jaegertracing.io/docs/latest/getting-started/

### Zipkin

- Run the server
- Run the server

```sh
# from this directory
$ npm run zipkin:server
```

- Run the client
- Run the client

```sh
# from this directory
npm run zipkin:client
```

#### Zipkin UI

`zipkin:server` script should output the `traceid` in the terminal (e.g `traceid: 4815c3d576d930189725f1f1d1bdfcc6`).
Go to Zipkin with your browser [http://localhost:9411/zipkin/traces/(your-trace-id)]() (e.g http://localhost:9411/zipkin/traces/4815c3d576d930189725f1f1d1bdfcc6)
Go to Zipkin with your browser <http://localhost:9411/zipkin/traces/(your-trace-id)> (e.g <http://localhost:9411/zipkin/traces/4815c3d576d930189725f1f1d1bdfcc6>)

<p align="center"><img src="./images/zipkin.jpg?raw=true"/></p>

### Jaeger

- Run the server
- Run the server

```sh
# from this directory
$ npm run jaeger:server
```

- Run the client
- Run the client

```sh
# from this directory
Expand All @@ -63,11 +65,12 @@ Go to Zipkin with your browser [http://localhost:9411/zipkin/traces/(your-trace-
#### Jaeger UI

`jaeger:server` script should output the `traceid` in the terminal (e.g `traceid: 4815c3d576d930189725f1f1d1bdfcc6`).
Go to Jaeger with your browser [http://localhost:16686/trace/(your-trace-id)]() (e.g http://localhost:16686/trace/4815c3d576d930189725f1f1d1bdfcc6)
Go to Jaeger with your browser <http://localhost:16686/trace/(your-trace-id)> (e.g <http://localhost:16686/trace/4815c3d576d930189725f1f1d1bdfcc6>)

<p align="center"><img src="images/jaeger.jpg?raw=true"/></p>

## Useful links

- For more information on OpenTelemetry, visit: <https://opentelemetry.io/>
- For more information on OpenTelemetry for Node.js, visit: <https://github.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-node>

Expand Down
15 changes: 9 additions & 6 deletions examples/fastify/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
OpenTelemetry Fastify Instrumentation allows the user to automatically collect trace data and export them to the backend of choice (Collector Exporter), to give observability to distributed systems.

This is a simple example that demonstrates tracing calls made to Fastify API. The example shows key aspects of tracing such as

- Root Span (on Client)
- Child Span (on Client)
- Span Events
Expand All @@ -11,15 +12,15 @@ This is a simple example that demonstrates tracing calls made to Fastify API. Th
## Installation

```sh
$ # from this directory
$ npm install
# from this directory
npm install
```

## Run the Application

### Collector - docker container

- Run docker container with collector
- Run docker container with collector

```sh
# from this directory
Expand All @@ -28,26 +29,28 @@ $ npm install

### Server

- Run the server
- Run the server

```sh
# from this directory
$ npm run server
```

- Run the client
- Run the client

```sh
# from this directory
npm run client
```

#### Zipkin UI
Go to Zipkin with your browser [http://localhost:9411/]()

Go to Zipkin with your browser <http://localhost:9411/>

<p align="center"><img src="images/trace1.png?raw=true"/></p>

## Useful links

- For more information on OpenTelemetry, visit: <https://opentelemetry.io/>
- For more information on OpenTelemetry for Node.js, visit: <https://github.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-node>

Expand Down
1 change: 1 addition & 0 deletions examples/graphql/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ npm install

5. You can also write your own queries, open page `http://localhost:4000/graphql`
6. You can also test a `graphql-transform-federation`

```shell script
# from this directory
npm run server:federation
Expand Down
Loading

0 comments on commit 6a1afe7

Please sign in to comment.