Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec compliance: OTEL_PROPAGATORS should still work when OTEL_SDK_DISABLED #7062

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mikeblum
Copy link

@mikeblum mikeblum commented Feb 1, 2025

…ABLED=false

@mikeblum mikeblum requested a review from a team as a code owner February 1, 2025 16:07
@mikeblum mikeblum force-pushed the gh-6939-otel-sdk-disabled-propagators branch 3 times, most recently from b4d723e to 1660f64 Compare February 1, 2025 17:01
@mikeblum mikeblum changed the title Spec compliance: OTEL_PROPAGATORS should still work when OTEL_SDK_DIS… Spec compliance: OTEL_PROPAGATORS should still work when OTEL_SDK_DISABLED Feb 1, 2025
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you see if you can add a test for this?

@mikeblum mikeblum force-pushed the gh-6939-otel-sdk-disabled-propagators branch 8 times, most recently from 3bc9876 to 1829e72 Compare February 2, 2025 18:53
Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.85%. Comparing base (cb64451) to head (198625e).

❌ Your project check has failed because the head coverage (89.97%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7062      +/-   ##
============================================
+ Coverage     89.84%   89.85%   +0.01%     
- Complexity     6610     6613       +3     
============================================
  Files           740      740              
  Lines         19981    19983       +2     
  Branches       1966     1966              
============================================
+ Hits          17951    17956       +5     
+ Misses         1440     1436       -4     
- Partials        590      591       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikeblum mikeblum force-pushed the gh-6939-otel-sdk-disabled-propagators branch 13 times, most recently from 54b1d8d to 137ee88 Compare February 3, 2025 00:15
@mikeblum mikeblum force-pushed the gh-6939-otel-sdk-disabled-propagators branch from 137ee88 to 198625e Compare February 3, 2025 00:18
@mikeblum mikeblum requested a review from trask February 3, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants