Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file configuration ComponentProvider support for samplers #6494

Merged
merged 7 commits into from
Aug 28, 2024

Conversation

jack-berg
Copy link
Member

Followup to #6457, #6493 adding file configuration support for custom Samplers.

As a part of this, adds ComponentProvider implementations for all the samplers maintained in this module (just JaegerRemoteSampler).

@jack-berg jack-berg requested a review from a team June 3, 2024 22:11
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 78.48101% with 17 lines in your changes missing coverage. Please review.

Project coverage is 90.02%. Comparing base (8495996) to head (209c2d6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ension/incubator/fileconfig/FileConfiguration.java 73.07% 5 Missing and 2 partials ⚠️
...extension/incubator/fileconfig/SamplerFactory.java 83.33% 3 Missing and 1 partial ⚠️
...internal/JaegerRemoteSamplerComponentProvider.java 73.33% 1 Missing and 3 partials ⚠️
...tor/fileconfig/YamlStructuredConfigProperties.java 85.71% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6494      +/-   ##
============================================
- Coverage     90.06%   90.02%   -0.04%     
- Complexity     6294     6302       +8     
============================================
  Files           698      699       +1     
  Lines         19032    19063      +31     
  Branches       1867     1870       +3     
============================================
+ Hits          17141    17162      +21     
- Misses         1315     1324       +9     
- Partials        576      577       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-berg
Copy link
Member Author

@open-telemetry/java-approvers could use a look when you have a chance. Thanks!

@jack-berg jack-berg merged commit 938b03d into open-telemetry:main Aug 28, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants