Exclude okhttp dependency from grpc-okhttp tests #3678
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
requested review from
arminru,
bogdandrutu,
carlosalberto and
jkwatson
as code owners
anuraaga
requested review from
Oberon00,
pavolloffay,
thisthat and
tylerbenson
as code owners
anuraaga
changed the title
|
Are there any downstream builds which have a dependency on a test source set? Also, is it worth excluding this dependency from the compile only dependencies? I.e. |
|
@jack-berg Yeah I was mostly trying to confirm it could be safe downstream to do the same as what we do here. But I realized that because we have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grpc-okhttpactually bundles in okhttp - they also have a few API knobs that use real okhttp classes, but we don't actually use these knobs. The tests passing with this change seem to confirm that we don't need to actually bring in the ancient okhttp version into downstream builds.For reference:
grpc/grpc-java#6119